envoy icon indicating copy to clipboard operation
envoy copied to clipboard

http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes

Open AdamEAnderson opened this issue 1 year ago • 2 comments

Commit Message: http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes Additional Description: See linked issue. This PR makes locally-originated resets use more reasonable HTTP2 error codes, especially focusing on not using NO_ERROR where inappropriate. It also improves the translation of HTTP2 error codes into StreamResetReasons for remote-originated HTTP2 resets. An integration test is included which tests the scenario outlined in the linked issue. Risk Level: medium. this may change behavior for existing http2 clients. Testing: included, may need more (?) Docs Changes: n/a Release Notes: included Fixes #36200

AdamEAnderson avatar Sep 18 '24 19:09 AdamEAnderson

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36203 was opened by AdamEAnderson.

see: more, trace.

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 20 '24 04:10 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 27 '24 08:10 github-actions[bot]