envoy icon indicating copy to clipboard operation
envoy copied to clipboard

deps/api: Bump `com_envoyproxy_protoc_gen_validate` -> 1.1.0

Open dependency-envoy[bot] opened this issue 1 year ago • 6 comments

Created by Envoy dependency bot for @phlax

Fix #35597

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

dependency-envoy[bot] avatar Aug 27 '24 13:08 dependency-envoy[bot]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @moderation

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/35866 was opened by dependency-envoy[bot].

see: more, trace.

requires patch update

/wait

phlax avatar Aug 27 '24 13:08 phlax

current patch appears to be no longer required but removing it and updating now throws

 external/com_envoyproxy_protoc_gen_validate/templates/cc/register.go:170:55: msg.Package().ProtoName().SplitOnDot undefined (type pgs.Name has no field or method SplitOnDot)

cc @adisuissa

/wait

phlax avatar Sep 12 '24 11:09 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 12 '24 12:10 github-actions[bot]

@phlax is this pr ready for review or should it be closed? Thanks!

/wait

tyxia avatar Oct 18 '24 16:10 tyxia

needs rebasing now that we have updated protobuf with the hope that the update resolves issue above

phlax avatar Oct 18 '24 16:10 phlax

my reading of https://github.com/bufbuild/protoc-gen-validate/pull/838 is that this requires a (go) update to protoc-gen-star

phlax avatar Oct 21 '24 13:10 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Dec 04 '24 16:12 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Dec 11 '24 20:12 github-actions[bot]