envoy icon indicating copy to clipboard operation
envoy copied to clipboard

original_dst: use localaddr if sock is transparent

Open electricjesus opened this issue 1 year ago • 1 comments

Commit Message: original_dst - use localaddr if sock is transparent Additional Description: original_dst to use localAddr if socket is transparent Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

electricjesus avatar Aug 27 '24 12:08 electricjesus

Hi @electricjesus, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/35860 was opened by electricjesus.

see: more, trace.

bump @kyessenov

phlax avatar Sep 02 '24 15:09 phlax

Can you please provide the motivation for this change? I think TPROXY is supported with the listener option https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener.proto#envoy-v3-api-field-config-listener-v3-listener-transparent and has been tested in the past.

Also, please clean up the diff and remove the orig files.

/wait

kyessenov avatar Sep 04 '24 21:09 kyessenov

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 05 '24 00:10 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 12 '24 04:10 github-actions[bot]