envoy
envoy copied to clipboard
envoyproxy
Exit_proc: Enable sending body without waiting for header response in STREAMED mode
Exit_proc: Enable sending body without waiting for header response in STREAMED mode
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/35850 was synchronize by yanjunxiang-google.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
@envoyproxy/api-shepherds PTAL and let me know if you have comments. Otherwise please approve.
Can you please reopen my comment https://github.com/envoyproxy/envoy/pull/35850#discussion_r1751546338 ? I am still confused. May be someone else can help me understanding.
@vikaschoudhary16 please check the newly added integration test: ServerWaitForBodyBeforeSendsHeaderRespStreamedTest
Please let me know if you have any further questions.
@vikaschoudhary16 please check the newly added integration test: ServerWaitForBodyBeforeSendsHeaderRespStreamedTest
Please let me know if you have any further questions.
Hey, thanks a lot. Really appreciate. I will take a look and get back if any questions
UPDATE: looks good. With your latest test's help I realized there was a concurrency issue in my ext-proc server. I was mistaken in my previous comments.
@vikaschoudhary16 please check the newly added integration test: ServerWaitForBodyBeforeSendsHeaderRespStreamedTest Please let me know if you have any further questions.
Hey, thanks a lot. Really appreciate. I will take a look and get back if any questions
UPDATE: looks good. With your latest test's help I realized there was a concurrency issue in my ext-proc server. I was mistaken in my previous comments.
Cool, thanks for confirming this!
LGTM. I will wait for other reviewer to approve and then merge.
/wait-any
Docs for this Pull Request will be rendered here:
https://storage.googleapis.com/envoy-pr/35850/docs/index.html
The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.
:cat:
Caused by: a https://github.com/envoyproxy/envoy/pull/35850#issuecomment-2372341653 was created by @tyxia.
/api lgtm
API is just for removing [not-implemented-hide], plus clarifying mode_override is not supported