envoy
envoy copied to clipboard
dynamic_forward_proxy: fix sub_cluster_confg stuck with warm up due to DFPCluster removed
Commit Message:
- A new attribute
ignore_removalhas been added to cluster spec. This attribute will prevent the cluster manager from removing clusters with value set to true. - A new function,
removeClusterAddedViaApi, has been added. This function can be used by custom implementations to remove clusters and manage dynamic clusters on their own.
Additional Description:
- Currently clusters that are dynamically added with custom implementations from filters, etc. are removed when a CDS event is triggered. This is because these dynamically created clusters will come in diff of CDS and will be removed by the cluster manager.
Risk Level: low Testing: unit test Docs Changes: no Release Notes: no Platform Specific Features: [Optional Runtime guard:] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
Fixes: #35171
Hi @itsLucario, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
@adisuissa Can you please help with review?
Ping @adisuissa I think this is waiting for opinion from you.
Pinged @adisuissa again, and also in slack.
/retest
also this needs a main merge /wait
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).
I'm trying to rerun the job, but it may need another main merge (due to a recent CI upgrade)
Seems that CI complains about coverage. Please follow link at https://github.com/envoyproxy/envoy/actions/runs/11157572663/job/31012169240#step:12:6358 to see the code that is not covered. /wait
/retest
/retest