envoy icon indicating copy to clipboard operation
envoy copied to clipboard

ext_authz: add logging options

Open antoniovleonti opened this issue 1 year ago • 6 comments

Commit Message: ext_authz: add logging options / stats Additional Description:

logging_options enables ext_authz to emit per-stream stats through filter state for access logging. The stats emitted depend on the client used.

If envoy GRPC is used, latency, bytes sent, bytes received, upstream host, and cluster info are emitted. Otherwise, only latency is emitted.

If logging_options.filter_metadata is present, ext_authz will also emit the filter metadata in its logging info.

ext authz will only emit stats & and filter metadata if a request is made.

Testing: unit & integration tests Docs Changes: none Release Notes: changelog updated Platform Specific Features: n/a

antoniovleonti avatar Aug 13 '24 21:08 antoniovleonti

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @markdroth CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/35698 was opened by antoniovleonti.

see: more, trace.

/assign tyxia

antoniovleonti avatar Aug 13 '24 22:08 antoniovleonti

/retest

antoniovleonti avatar Aug 14 '24 11:08 antoniovleonti

/lgtm api

markdroth avatar Aug 16 '24 14:08 markdroth

@tyxia can you PTAL?

adisuissa avatar Aug 20 '24 20:08 adisuissa

/retest

antoniovleonti avatar Aug 21 '24 17:08 antoniovleonti

@markdroth @tyxia i think this may be waiting on further review

@antoniovleonti if you merge main the current arm fail should be resolved

phlax avatar Sep 03 '24 16:09 phlax

/lgtm api

markdroth avatar Sep 06 '24 17:09 markdroth

/retest

antoniovleonti avatar Sep 10 '24 21:09 antoniovleonti

@antoniovleonti Looks like retest did not work, please merge main to re-trigger the CI. Thanks!

tyxia avatar Sep 10 '24 23:09 tyxia

/retest

antoniovleonti avatar Sep 11 '24 15:09 antoniovleonti

/retest

antoniovleonti avatar Sep 11 '24 19:09 antoniovleonti