envoy icon indicating copy to clipboard operation
envoy copied to clipboard

deps: update absl, googleapis, cel-cpp

Open kyessenov opened this issue 1 year ago • 15 comments

Commit Message: update absl, googleapis, cel-cpp Risk Level: low

kyessenov avatar Jul 30 '24 23:07 kyessenov

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @moderation

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/35514 was opened by kyessenov.

see: more, trace.

/assign @yanavlasov

soulxu avatar Jul 31 '24 05:07 soulxu

/wait-any

soulxu avatar Jul 31 '24 05:07 soulxu

@kyessenov this adds 100s of lines of warnings to most of our builds

can we either fix this upstream before merging or patch out the warnings if they are not important

phlax avatar Jul 31 '24 13:07 phlax

@phlax, yeah I can fix upstream. There's work to do here with various static asserts too.

kyessenov avatar Jul 31 '24 17:07 kyessenov

Deps looks good and will check back when CI errors are fixed

moderation avatar Aug 01 '24 03:08 moderation

/wait

yanavlasov avatar Aug 01 '24 13:08 yanavlasov

@kyessenov regarding the iOS/macOS failures, if I change the Abseil library to be the previous one, i.e.

version = "20230802.1",
sha256 = "987ce98f02eefbaf930d6e38ab16aa05737234d7afbab2d5c4ea7adbe50c28ed",

then it builds properly. It seems like this version of the Abseil library has issues in its macOS/iOS target build?

abeyad avatar Aug 01 '24 18:08 abeyad

@abeyad macOS build failure is distinct - it's something about alignment difference. I am not sure how iOS build error is triggered - is it using clang 14 or some strange compiler version?

kyessenov avatar Aug 01 '24 18:08 kyessenov

@abeyad macOS build failure is distinct - it's something about alignment difference. I am not sure how iOS build error is triggered - is it using clang 14 or some strange compiler version?

I'm using clang 15 locally on my mac and it fails to build with the same error as the iOS job. Note that I'm using the option --config=mobile-test-ios (which results in these options: https://github.com/envoyproxy/envoy/blob/770fa7ba2b61e11b267e27b0d4c4861c4b20c11a/mobile/.bazelrc#L69-L71).

abeyad avatar Aug 01 '24 18:08 abeyad

Sigh, I don't have a Mac. And it's also quic code. Any way to proceed debugging besides Googling for some other reports of a build failure?

kyessenov avatar Aug 02 '24 21:08 kyessenov

I see two problems:

  1. Link failure with undefined _FLAGS_v in quic::QuicCryptoClientConfig::CachedState::Initialize - IOS and Android are likely the same problem. My guess it is produced by QUIC_DVLOG(1) but, I'm unsure what needs to be logged to make it work. I'll ping the QUIC team to assist.
  2. Alignment error in CEL for macOS build. Not sure about this one.

yanavlasov avatar Aug 26 '24 15:08 yanavlasov

/wait

yanavlasov avatar Aug 27 '24 13:08 yanavlasov

/retest

kyessenov avatar Aug 28 '24 16:08 kyessenov

/retest

kyessenov avatar Aug 29 '24 00:08 kyessenov

ci fails look real

/wait

phlax avatar Sep 03 '24 16:09 phlax

For the macOS failure: https://github.com/google/cel-cpp/issues/831

asedeno avatar Sep 05 '24 18:09 asedeno

The macOS build failure should be fixed by bumping CEL to https://github.com/google/cel-cpp/commit/aafa026e4c8c7177ef1364bbcee92992ba7fbb61.

That's going to require bumping protobuf too though.

asedeno avatar Sep 05 '24 21:09 asedeno

I'd like to decouple the absl update from the cel update, just to untangle the various build failures. Was 20240116.2 chosen over 20240722.0 for any particular reason? It was pretty new when this PR was opened.

[edit:] ah, I see that 20240722.0 was released August 1st, after this PR was opened.

asedeno avatar Sep 09 '24 15:09 asedeno

@asedeno i tried updating absl on its own previously and iirc came to the conclusion that it would need a CEL update also - at least without patching

phlax avatar Sep 09 '24 15:09 phlax

@phlax, I'm a bit late to this party and also arriving to the same conclusion. I might poke at it some more just to satisfy my own curiosity.

asedeno avatar Sep 09 '24 15:09 asedeno

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 09 '24 16:10 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 16 '24 20:10 github-actions[bot]