envoy
envoy copied to clipboard
envoyproxy
oauth: ability to specify SameSite cookie attribute value
Commit Message: oauth: ability to specify SameSite cookie attribute value
Additional Description: The SameSite attribute has three different values to allow control over whether the cookies get shared same-site/cross-site. It's optional so there's also a Disabled option which excludes the SameSite attribute. This is the default setting so existing deployments are not modified in any way, but now operators can enable SameSite.
Risk Level: Low
Testing: unit
Docs Changes: proto is documented
Release Notes: changelog entry added
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/35455 was opened by derekargueta.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/35455 was opened by derekargueta.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@derekargueta thanks for initiating this work -- are you still working on this? we have an interest to be able to set the cookie attribute.
We are also looking forward to the fix here. Any plan to restart to effort?
We are also looking forward to the fix here. Any plan to restart to effort?
Hi @mchen391 Lyft will take this work and continue the testing. I will be working on this.
@Yueren-Wang what's your expected timeline to work-on/fix this?
I am a new contributor, So I am targeting to get this commit checked in and shipped by end of this year, taking into account that the holiday season may cause some delays.