envoy
envoy copied to clipboard
envoyproxy
conn pool: use hostnames of endpoints as SNI values
Commit Message: conn pool: use hostnames of endpoints as SNI values Additional Description: optional support for usage of upstream cluster endpoints' hostnames as SNI values. This PR is the successor of 34898 with expected improvement of test flakiness. Original PR was reverted by 35212. Risk Level: Low Testing: integration Docs Changes: added information about new mechanism of SNI derivation Release Notes: https://github.com/dmitriyilin/envoy/blob/0f70012a2383dd56cb070199664be44dbd8bbd93/changelogs/current.yaml#L16 Platform Specific Features: N/A Fixes https://github.com/envoyproxy/envoy/issues/15839
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/35380 was opened by dmitriyilin.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
fyi, I took "ProxyFilterIntegrationTest, UpstreamTlsInvalidSAN" as basis for the test that was showing flaky behavior "AutoSniIntegrationTest, AutoSniFromUpstreamAndAutoSanValidationFailureTest".
Assigning Matt who also reviewed #34898. Can you provide more info about how the flaky test was fixed? /assign @mattklein123
Assigning Matt who also reviewed #34898. Can you provide more info about how the flaky test was fixed? /assign @mattklein123
I had used ProxyFilterIntegrationTest. UpstreamTlsInvalidSAN test as the basis and added missed configuration:
FakeUpstream.setReadDisableOnNewConnection(false)
As flaky test validates behaviour in case of failure, I've added explicit cleanup: HttpIntegrationTest.cleanupUpstreamAndDownstream()
Hey! This is exactly the feature I'm needing. Do you think it's possible to do the same using current Envoy's release configuration?
Hey! This is exactly the feature I'm needing. Do you think it's possible to do the same using current Envoy's release configuration?
It's a new functionality, so new config is needed.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yanavlasov, @adisuissa, @mattklein123 do you see any issues with the changes?
