envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Removes unused createStaticConfigProvider

Open mathetake opened this issue 1 year ago • 2 comments

Commit Message: Removes unused createStaticConfigProvider Additional Description: Previously, a variant of createStaticConfigProvider taking Protobuf::Message as a first param was not used, and that was one reason for the low test coverage of envoy/config package. This removes it, and potentially allows the package to be removed from the coverage exception.

Risk Level: low Testing: done Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

mathetake avatar Jun 30 '24 17:06 mathetake

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34985 was opened by mathetake.

see: more, trace.

/retest

mathetake avatar Jun 30 '24 19:06 mathetake