envoy
envoy copied to clipboard
envoyproxy
Add logging util lib for Proto Message Logging (PML) http filter
Commit Message: Add logging util lib for Proto Message Logging (PML) http filter Additional Description: This functionality will be used in the PML filter Risk Level: Low Testing: Added unit tests Docs Changes: The proto for PML filter is present at api/envoy/extensions/filters/http/proto_message_logging/v3/config.proto Release Notes: Nil Platform Specific Features: Nil
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34955 was opened by dchakarwarti.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dchakarwarti have you followed the extension policy? Does this extension have a maintainer sponsor?
@dchakarwarti have you followed the extension policy? Does this extension have a maintainer sponsor?
Yes, we have followed the extension policy. The config proto for the PML filter has already been submitted previously: https://github.com/envoyproxy/envoy/pull/31735.
@yanavlasov is our sponsor.
Hi Yan!
Can you please take a look at the changes?
Thank you! cc: @yanavlasov
LGTM from me. Please merge main to fix the coverage build.
I will wait for @kyessenov approval and then merge.
LGTM from me. Please merge main to fix the coverage build.
I will wait for @kyessenov approval and then merge.
Sure, addressed the coverage build.
Added some more unit tests. Requesting a review please.
Thank you!
