envoy icon indicating copy to clipboard operation
envoy copied to clipboard

[bp/1.28] Bump rules-go to 0.41.0

Open jwendell opened this issue 1 year ago • 5 comments

This version contains the fix for using local sdk with go >= 1.21

https://github.com/bazelbuild/rules_go/pull/3600

jwendell avatar Jun 26 '24 18:06 jwendell

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @moderation

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34941 was opened by jwendell.

see: more, trace.

/retest

jwendell avatar Jun 28 '24 15:06 jwendell

ci failures look ~real

Repository rule http_archive defined at:
  /build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in <toplevel>
ERROR: /build/bazel_root/base/external/com_github_cncf_xds_go/xds/type/v3/BUILD.bazel:3:11: no such package '@go_googleapis//google/api/expr/v1alpha1': The repository '@go_googleapis' could not be resolved: Repository '@go_googleapis' is not defined and referenced by '@com_github_cncf_xds_go//xds/type/v3:type'
ERROR: Analysis of target '//contrib/golang/router/cluster_specifier/test/test_data/simple:plugin.so' failed; build aborted: 
INFO: Elapsed time: 49.836s
INFO: 0 processes.

this has come up before @mmorel-35 might know why this happens

phlax avatar Jun 28 '24 15:06 phlax

that's weird, we already applied that change to our fork and it's building fine...

jwendell avatar Jun 28 '24 15:06 jwendell

Please have a look over here https://github.com/envoyproxy/envoy/pull/33084/files

mmorel-35 avatar Jun 28 '24 17:06 mmorel-35

Current main branch rules_go is at 0.46.0 - should we bump to that version?

moderation avatar Jul 01 '24 18:07 moderation

Current main branch rules_go is at 0.46.0 - should we bump to that version?

i think lets land these (once ci issues are resolved)

we can bump main further and backport more if required

phlax avatar Jul 01 '24 19:07 phlax

hmm - actually @jwendell i just realized that this isnt actually a backport - i think @moderation is right - that we should just pick the actual backport - same with PRs on other branches

phlax avatar Jul 02 '24 14:07 phlax

Yeah, you're right, this is not a backport. I was just trying to be moderate and bump the versions only to the minimal version required, but if bringing it in pair with main is not an issue, I'll do it.

Thanks for the review folks.

jwendell avatar Jul 02 '24 14:07 jwendell