envoy icon indicating copy to clipboard operation
envoy copied to clipboard

conn pool: use hostnames of endpoints as SNI values

Open dmitriyilin opened this issue 1 year ago • 4 comments

Commit Message: conn pool: use hostnames of endpoints as SNI values Additional Description: optional support for usage of upstream cluster endpoints' hostnames as SNI values Risk Level: Low Testing: integration Docs Changes: added information about new mechanism of SNI derivation Release Notes: https://github.com/dmitriyilin/envoy/blob/b8e8a4537e537da66925f442cd5aeb45094cc3c9/changelogs/current.yaml#L377 Platform Specific Features: N/A Fixes #15839

dmitriyilin avatar Jun 25 '24 15:06 dmitriyilin

Hi @dmitriyilin, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34898 was opened by dmitriyilin.

see: more, trace.

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @abeyad CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34898 was opened by dmitriyilin.

see: more, trace.

I see that "Publish and verify" check fails in other PRs as well. Is anything required from me?

dmitriyilin avatar Jun 26 '24 10:06 dmitriyilin

Just realized that "auto_san_validation" functionality is not consistent with the new mechanism. I'll fix it.

dmitriyilin avatar Jun 26 '24 11:06 dmitriyilin

@mattklein123 , @abeyad I've fixed SAN validation. Can you review the changes?

dmitriyilin avatar Jul 01 '24 18:07 dmitriyilin

FYI, I'll be OOO for a couple weeks, so if this PR has API changes again that need further review, you probably want to find another API reviewer, thanks!

abeyad avatar Jul 10 '24 16:07 abeyad

@mattklein123 , can you help finding a new member of API shepherds for reviewing the change? Does @envoyproxy/api-shepherds referencing work?

dmitriyilin avatar Jul 15 '24 11:07 dmitriyilin