envoy icon indicating copy to clipboard operation
envoy copied to clipboard

mobile: Cache AndroidNetworkLibrary and AndroidCertVerifyResult classes

Open fredyw opened this issue 1 year ago • 1 comments

This PR adds AndroidNetworkLibrary and AndroidCertVerifyResult classes into the cache to be consistent with the rest of the code. This PR also deletes the need to load a ClassLoader to find a non-built in class because all the classes have already been cached.

Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: mobile

fredyw avatar May 30 '24 20:05 fredyw

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34434 was opened by fredyw.

see: more, trace.

/assign @abeyad

fredyw avatar May 31 '24 21:05 fredyw

/retest

fredyw avatar May 31 '24 22:05 fredyw

/retest

fredyw avatar Jun 01 '24 00:06 fredyw

/retest

fredyw avatar Jun 01 '24 01:06 fredyw

/retest

fredyw avatar Jun 01 '24 02:06 fredyw

/retest

fredyw avatar Jun 01 '24 13:06 fredyw

/retest

fredyw avatar Jun 01 '24 19:06 fredyw

/retest

fredyw avatar Jun 01 '24 21:06 fredyw

/retest

fredyw avatar Jun 02 '24 01:06 fredyw