envoy icon indicating copy to clipboard operation
envoy copied to clipboard

dns: removing exceptions from resolver

Open alyssawilk opened this issue 1 year ago • 2 comments

Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a https://github.com/envoyproxy/envoy-mobile/issues/176

alyssawilk avatar May 29 '24 13:05 alyssawilk

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34409 was opened by alyssawilk.

see: more, trace.

Yanjun -- can you do a first pass? After your lgtm I'll assign a maintainer.

jmarantz avatar May 30 '24 15:05 jmarantz

LGTM modulo CI error.

yanjunxiang-google avatar May 31 '24 13:05 yanjunxiang-google

@ravenblackx for non-google review (just realized I don't need a senior maintainer since Alyssa is).

jmarantz avatar May 31 '24 20:05 jmarantz

yeah I prefer THROW_OR_SET_VALUE to foo_or_error = function THROW_IF_STATUS_NOT_OK(foo_or_error.status() foo = foo_or_error.value() so I tend to use it when there's setters involved.

alyssawilk avatar Jun 03 '24 14:06 alyssawilk