envoy
envoy copied to clipboard
dns: removing exceptions from resolver
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a https://github.com/envoyproxy/envoy-mobile/issues/176
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
Yanjun -- can you do a first pass? After your lgtm I'll assign a maintainer.
LGTM modulo CI error.
@ravenblackx for non-google review (just realized I don't need a senior maintainer since Alyssa is).
yeah I prefer THROW_OR_SET_VALUE to foo_or_error = function THROW_IF_STATUS_NOT_OK(foo_or_error.status() foo = foo_or_error.value() so I tend to use it when there's setters involved.