envoy
envoy copied to clipboard
aws: key derivation fix and test case
Commit Message: fix for sigv4a key derivation error and add test cases to cover Additional Description: Bug introduced (by me) in https://github.com/envoyproxy/envoy/pull/32487 Risk Level: Low Testing: Unit Docs Changes: N/A Release Notes: N/A Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
/assign nbaws
nbaws cannot be assigned to this issue.
/assign @nbaws
@nbaws cannot be assigned to this issue.
/retest
@suniltheta @lavignes can you PTAL at the PR?
Thanks for fixing this. Minor nits, but otherwise LGTM!
more fundamental fixes for this included. ty for your review!
Previously approved by @suniltheta (code-owner), merging.