envoy icon indicating copy to clipboard operation
envoy copied to clipboard

aws: key derivation fix and test case

Open nbaws opened this issue 1 year ago • 5 comments

Commit Message: fix for sigv4a key derivation error and add test cases to cover Additional Description: Bug introduced (by me) in https://github.com/envoyproxy/envoy/pull/32487 Risk Level: Low Testing: Unit Docs Changes: N/A Release Notes: N/A Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

nbaws avatar May 28 '24 00:05 nbaws

/assign nbaws

suniltheta avatar May 28 '24 17:05 suniltheta

nbaws cannot be assigned to this issue.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/34377#issuecomment-2135795288 was created by @suniltheta.

see: more, trace.

/assign @nbaws

suniltheta avatar May 28 '24 17:05 suniltheta

@nbaws cannot be assigned to this issue.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/34377#issuecomment-2135795949 was created by @suniltheta.

see: more, trace.

/retest

nbaws avatar May 28 '24 22:05 nbaws

@suniltheta @lavignes can you PTAL at the PR?

adisuissa avatar Jun 04 '24 03:06 adisuissa

Thanks for fixing this. Minor nits, but otherwise LGTM!

more fundamental fixes for this included. ty for your review!

nbaws avatar Jun 06 '24 03:06 nbaws

Previously approved by @suniltheta (code-owner), merging.

adisuissa avatar Jun 10 '24 14:06 adisuissa