envoy
envoy copied to clipboard
envoyproxy
Add the ability to bypass overload manager for listeners
Commit Message: Add the ability to bypass overload manager for listeners Additional Description: This flag can be used to disable overload manager on specific listeners where, for instance, we don't want to stop accepting requests. In my company, we implemented a CPU Utilization resource monitor that helps us drop requests when we hit a certain utilization percentage, but there are certain listeners that receive administrative traffic that we don't want overload manager to touch. Another use case is, we want to only throttle ingress traffic but not egress traffic going via Envoy. Another contributor authored https://github.com/envoyproxy/envoy/pull/29781, but it has been marked as stale.
Risk Level: Low Testing: Unit tests & Integration tests added Docs Changes: No Release Notes: Add bypass_overload_manager flag to Listener in order to prevent overload manager from taking actions on the traffic going through the said listener. Platform Specific Features:
Hi @cancecen, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34322 was opened by cancecen.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34322 was opened by cancecen.
Thank you for working on this. Can you include release notes? Also the CI failure looks legit.
Added the release notes, will investigate the CI failure.
CI is all passing now. Please let me know what you think. @RyanTheOptimist @lizan @KBaichoo