envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

rename getTraceIdAsHex to getTraceId

Open zirain opened this issue 1 month ago • 2 comments

Commit Message: rename getTraceIdAsHex to getTraceId, becasuse not all tracer providers use hex format trace id. Additional Description: follow up https://github.com/envoyproxy/envoy/pull/34198 Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

zirain avatar May 23 '24 06:05 zirain

looks good to me. Could you check the ci? Thanks.

/wait

wbpcode avatar May 23 '24 09:05 wbpcode

/retest

zirain avatar May 23 '24 14:05 zirain