envoy icon indicating copy to clipboard operation
envoy copied to clipboard

dfp: adding an experimental option for E-M

Open alyssawilk opened this issue 1 year ago • 4 comments

This adds an off-by-default flag that allows the DFP filter to force resolution if there are no upstream connections. This doesn't work for strict DNS, and is largely intended for use for Envoy mobile. As the TODO states, if the performance is net positive we'll add configuration knobs, otherwise it'll be torn out.

Risk Level: low (off by default) Testing: new e2e tests Docs Changes: n/a Release Notes: n/a [Optional Runtime guard:] yes

alyssawilk avatar May 21 '24 19:05 alyssawilk

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34282 was opened by alyssawilk.

see: more, trace.

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34282 was opened by alyssawilk.

see: more, trace.

/wait on CI

alyssawilk avatar May 21 '24 20:05 alyssawilk

/retest

alyssawilk avatar May 23 '24 15:05 alyssawilk

/retest

alyssawilk avatar May 28 '24 16:05 alyssawilk

OK ci sorted, PTAL

alyssawilk avatar May 28 '24 17:05 alyssawilk