envoy icon indicating copy to clipboard operation
envoy copied to clipboard

xds-failover: adding main logic

Open adisuissa opened this issue 9 months ago • 5 comments

Commit Message: xds-failover: adding main logic Additional Description: Adding the main logic for the xDS-failover support. It currently supports a primary and failover sources. Initially, the manager attempts to connect to the primary twice, and if both fail, alternates between the failover and the primary until one is successfully connected to. Once a connection is made (a response arrives) from either source, the failover manager will stick to that source.

Risk Level: low - not plumbed into any GrpcMux object yet. Testing: Added unit test. Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

adisuissa avatar May 17 '24 02:05 adisuissa

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34215 was opened by adisuissa.

see: more, trace.

Harvey PTAL. LMK if you want more context (I've got an internal integration test the exercises this code). /assign @htuch

adisuissa avatar May 17 '24 03:05 adisuissa

Assigning @soulxu as !Google maintainer reviewer. /assign @soulxu

adisuissa avatar May 21 '24 17:05 adisuissa

Unassigning @soulxu as he is OOO this week. @wbpcode can you please take a ~Google pass at this PR?

adisuissa avatar May 22 '24 02:05 adisuissa

@nezdolik will you have some bandwidth to review this PR as a !Google reviewer? Thanks in advance!

adisuissa avatar May 24 '24 21:05 adisuissa