envoy icon indicating copy to clipboard operation
envoy copied to clipboard

mobile: Make C++17 a default build target

Open fredyw opened this issue 9 months ago • 5 comments

This is so that when building it locally, it will also use C++17 without having to manually pass --cxxopt=-std=c++17 --host_cxxopt=-std=c++17.

Risk Level: low Testing: CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

fredyw avatar May 16 '24 17:05 fredyw

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34209 was opened by fredyw.

see: more, trace.

fwiw im just about to test the newer ndk https://github.com/envoyproxy/envoy-build-tools/commit/6474ce1eddb779bd0fd1ca3a60995687fbf00bb4

phlax avatar May 16 '24 17:05 phlax

/retest

fredyw avatar May 21 '24 00:05 fredyw

/retest

fredyw avatar May 21 '24 00:05 fredyw

/retest

fredyw avatar May 21 '24 01:05 fredyw

/assign @abeyad

fredyw avatar May 21 '24 15:05 fredyw