envoy icon indicating copy to clipboard operation
envoy copied to clipboard

gRPC API: Add support to control the internal request headers

Open tyxia opened this issue 1 year ago • 4 comments

This is the follow-up of https://github.com/envoyproxy/envoy/pull/34125.

https://github.com/envoyproxy/envoy/pull/34125 provides the way to remove x-envoy-internal and x-forwarded-for in http asyncClient path. This API PR provides the config options for envoy-gRPC (which is on top of http asyncClient) to remove x-envoy-internal and x-forwarded-for.

By default, those two config options are TRUE, which keeps the existing behavior. And next in the impl, envoy-gRPC client can config these two options(setting them to FALSE) to not add those two headers.

tyxia avatar May 15 '24 16:05 tyxia

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34179 was opened by tyxia.

see: more, trace.

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @lizan CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34179 was opened by tyxia.

see: more, trace.

/assign @htuch @lizan

PTAL, Thanks!

tyxia avatar May 15 '24 23:05 tyxia

/wait (for CI to be made green)

jmarantz avatar May 30 '24 16:05 jmarantz

/retest

tyxia avatar Jun 26 '24 16:06 tyxia

/retest

tyxia avatar Jun 27 '24 12:06 tyxia