envoy icon indicating copy to clipboard operation
envoy copied to clipboard

connect: regression testing bugfix

Open alyssawilk opened this issue 1 year ago • 5 comments

Commit Message: n/a Additional Description: n/a Risk Level: n/a (test only) Testing: yep tests https://github.com/envoyproxy/envoy/issues/34096

alyssawilk avatar May 13 '24 13:05 alyssawilk

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34112 was opened by alyssawilk.

see: more, trace.

I was thinking maybe the fix should be in Envoy's BalsaParser implementation?

It kinda scares me that after the parser finishes executing an input, the headers_ object is cleared. Maybe the headers should just stay?

RenjieTang avatar May 13 '24 17:05 RenjieTang

yeah said on ucn chat, I'm hoping we can land a real fix in google3 ASAP at which point I'll put this on hold, and use it to regression test after import lands. If we can't get a balsa fix in by wednesday we can patch this workaround in as a temporary thing.

alyssawilk avatar May 13 '24 17:05 alyssawilk

/wait on decision making

alyssawilk avatar May 14 '24 12:05 alyssawilk

balsa fix landed, so this is now a test-only change

alyssawilk avatar May 15 '24 20:05 alyssawilk

/retest

alyssawilk avatar May 16 '24 12:05 alyssawilk