envoy
envoy copied to clipboard
connect: regression testing bugfix
Commit Message: n/a Additional Description: n/a Risk Level: n/a (test only) Testing: yep tests https://github.com/envoyproxy/envoy/issues/34096
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
I was thinking maybe the fix should be in Envoy's BalsaParser implementation?
It kinda scares me that after the parser finishes executing an input, the headers_ object is cleared. Maybe the headers should just stay?
yeah said on ucn chat, I'm hoping we can land a real fix in google3 ASAP at which point I'll put this on hold, and use it to regression test after import lands. If we can't get a balsa fix in by wednesday we can patch this workaround in as a temporary thing.
/wait on decision making
balsa fix landed, so this is now a test-only change
/retest