envoyproxy
hcm: add match_upstream to SchemeHeaderTransformation
Commit Message: add match_upstream to SchemeHeaderTransformation
Additional Description: Define a new variant that configures the hcm to override the scheme with the upstream transport protocol. The value is accessible by all downstream filters and is specifically used by the Router filter. Renamed variant from use_upstream_scheme to be clear that the scheme matches the transport protocol.
Risk Level: low
Testing: unit testing
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #33020
Hi @wtzhang23, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34099 was opened by wtzhang23.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34099 was opened by wtzhang23.
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34099 was opened by wtzhang23.
Small Qs:
- Not familiar with the async client implementation. Is it possible that especially the gRPC client may take advantage of these settings?
- What setting should the Admin interface use? I have it set to true which from my understanding will be a no-op.
- Pass the
should_match_upstreamas a constructor param or keep using a setter in StreamInfo?
@envoyproxy/senior-maintainers assignee is @htuch
:cat:
Caused by: a https://github.com/envoyproxy/envoy/pull/34099#pullrequestreview-2053335351 was submitted by @adisuissa.
