envoy
envoy copied to clipboard
Implement setOperation for the opentelemetry provider
Commit Message: implement setOperation for the opentelemetry provider
Additional Description:
The detailed description is provided in issue#34063. In short, the MR implements a method for the OpenTelemetry tracing provider that was left empty and thus made the setOperation
method a no-op.
Risk Level: Low
Testing: Unit testing and the sandbox.
Fixes issue#34063
Hi @therealak12, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
The ci/do_ci.sh verify_examples
check failed likely due to the following error. I'd appreciate any help on how to fix it.
#6 [wasm_compile_update stage-0 2/2] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked --mount=type=cache,target=/var/lib/apt/lists,sharing=locked apt-get -qq install --no-install-recommends -y gosu && groupadd -f envoygroup && useradd -g envoygroup -m -d /home/envoybuild envoybuild
#6 0.224 E: Unable to locate package gosu
#6 ERROR: process "/bin/bash -ec apt-get -qq install --no-install-recommends -y gosu && groupadd -f envoygroup && useradd -g envoygroup -m -d /home/envoybuild envoybuild" did not complete successfully: exit code: 100
------
> [wasm_compile_update stage-0 2/2] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked --mount=type=cache,target=/var/lib/apt/lists,sharing=locked apt-get -qq install --no-install-recommends -y gosu && groupadd -f envoygroup && useradd -g envoygroup -m -d /home/envoybuild envoybuild:
0.224 E: Unable to locate package gosu
------
failed to solve: process "/bin/bash -ec apt-get -qq install --no-install-recommends -y gosu && groupadd -f envoygroup && useradd -g envoygroup -m -d /home/envoybuild envoybuild" did not complete successfully: exit code: 100
its actually a slightly different error (single-page-app
) - the one posted above is known flakey so is caught as a warning - not sure exactly the cause
/retest
Thanks for rerunning the Publish and verify
job. Now The CodeQL/push...
job is failing with java.io.IOException: No space left on device
.
/retest
Haha. 😂 Inadvertently closed and reopened the pull request. I didn't know it would result in rerunning the jobs. By the way, the checks are all passed. 🥳
@therealak12 a sandbox test is helpful also, but probably this shoud have some code test if its critical to functionality
@phlax It depends on how we define critical. Nonetheless, being compatible with Envoy docs is important enough to have tests for. So, thanks for reminding me. I'll add proper tests.
I'm going to mark the PR as draft till I add the tests.
/retest
@phlax I added a new test for the intended scenario. Marking the PR as ready for review.
Dear @htuch; Kindly please let me know if there's anything else I can do to move forward with the review process.