envoy icon indicating copy to clipboard operation
envoy copied to clipboard

quic: add listener config option to attach connection debug visitors

Open wlampert opened this issue 1 year ago • 7 comments

Commit Message: Add a way to configure a quic connection debug visitor factory that will be used to attach a debug visitor to all quic connections on the listener. Adds an interface for this new type of factory. Additional Description: Risk Level: Low Testing: Added new tests and modified existing tests in /test/common/quic. Also performed manual testing on a real machine and sent traffic to it using quic_client. Docs Changes: Update envoy.config.listener.v3.quic_config.proto inline. Release Notes: N/A Platform Specific Features: N/A [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

wlampert avatar May 09 '24 04:05 wlampert

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @wbpcode CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34036 was opened by wlampert.

see: more, trace.

/assign @RyanTheOptimist

wlampert avatar May 09 '24 04:05 wlampert

FYI: It looks like there is a docs issue:

https://dev.azure.com/cncf/envoy/_build/results?buildId=170030&view=logs&jobId=9fd58ae0-0c50-56b1-f517-c2b9afda9c9b&j=9fd58ae0-0c50-56b1-f517-c2b9afda9c9b&t=f871f0ce-3dc6-5bd2-7916-5ec61dbe723c

RyanTheOptimist avatar May 09 '24 14:05 RyanTheOptimist

/wait

RyanTheOptimist avatar May 10 '24 13:05 RyanTheOptimist

/retest

wlampert avatar May 20 '24 17:05 wlampert

Looks like an MSAN failure:

[  FAILED  ] QuicHttpIntegrationTests/QuicHttpIntegrationTest.ConnectionDebugVisitor/IPv4, where GetParam() = 4-byte object <00-00 00-00>

RyanTheOptimist avatar May 20 '24 22:05 RyanTheOptimist

@wbpcode friendly ping for the API review.

RyanTheOptimist avatar May 29 '24 18:05 RyanTheOptimist

This looks like it's causing flakes - Will can you triage?

alyssawilk avatar Jun 03 '24 20:06 alyssawilk