envoy icon indicating copy to clipboard operation
envoy copied to clipboard

dlb: upgrade to 8.8

Open daixiang0 opened this issue 1 year ago • 4 comments

Commit Message: Upgrade libdlb to 8.8 Additional Description: Risk Level: Low Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

daixiang0 avatar Apr 28 '24 02:04 daixiang0

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @moderation

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33834 was opened by daixiang0.

see: more, trace.

Now the latest layout is like:

dlb
├── driver
│   └── dlb2
│       ├── user.h
└── libdlb
    ├── Makefile

I want to run make under libdlb dir and it depends on driver/dlb2/user.h.

I can not use filegroup() to include the user.h since it would make bazel cannot find Makefile.

I also tried to copy this header file into libdlb dir, but failed to find a way to do it.

@phlax is there a way to do it?

daixiang0 avatar Apr 28 '24 08:04 daixiang0

@phlax @adisuissa sorry that I add some local changes here :(

daixiang0 avatar May 06 '24 01:05 daixiang0

I try to move files into one dir by Bazel and fail, so I just move the file by patch.

daixiang0 avatar May 07 '24 02:05 daixiang0