envoy
envoy copied to clipboard
router: set upstream host from the conn pool
Commit Message: router: set upstream host from the conn pool Additional Description:
The host() method of connection pool will return a host in current implementation. We can set the host at constructor of UpstreamRequest and needn't to wait the pool callbacks.
Considering a scenario like this, if the request is timeout before any pool callbacks are called, then the upstream host will never be set and we can even cannot know which host is selected for this request from the access log.
Risk Level: mid, core logic change. Testing: wait. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a.
/wait
~~Will try to clean up the pool callbacks parameter list by another PR, if I can finally ensure the host() method will always return a valid host~~
multiple addresses....
/wait fix ci
/wait ci
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!