envoy icon indicating copy to clipboard operation
envoy copied to clipboard

router: set upstream host from the conn pool

Open wbpcode opened this issue 1 year ago • 5 comments
trafficstars

Commit Message: router: set upstream host from the conn pool Additional Description:

The host() method of connection pool will return a host in current implementation. We can set the host at constructor of UpstreamRequest and needn't to wait the pool callbacks.

Considering a scenario like this, if the request is timeout before any pool callbacks are called, then the upstream host will never be set and we can even cannot know which host is selected for this request from the access log.

Risk Level: mid, core logic change. Testing: wait. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a.

wbpcode avatar Apr 25 '24 13:04 wbpcode

/wait

wbpcode avatar Apr 25 '24 13:04 wbpcode

~~Will try to clean up the pool callbacks parameter list by another PR, if I can finally ensure the host() method will always return a valid host~~

wbpcode avatar Apr 25 '24 13:04 wbpcode

multiple addresses....

wbpcode avatar Apr 26 '24 08:04 wbpcode

/wait fix ci

wbpcode avatar Apr 26 '24 15:04 wbpcode

/wait ci

wbpcode avatar Apr 27 '24 12:04 wbpcode

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 13 '24 20:06 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 21 '24 00:06 github-actions[bot]