envoy icon indicating copy to clipboard operation
envoy copied to clipboard

gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes

Open dmateusp opened this issue 1 year ago • 2 comments

gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes:

Currently the gRPC HTTP/1.1 bridge sets the HTTP response code to 503 for any non-0 gRPC codes, it would be great to use a sensible mapping to HTTP response codes instead.

Description:

The mapping in the bridge could be changed to set the HTTP response code based on the mapping you can find in the comments of googleapis/google/rpc/code.proto instead of using 503. In our case it would be useful to return these codes for monitoring / logging on our GCP load balancer.

Relevant Links

See gRPC HTTP bridge docs "the filter switches the HTTP response code to 503"

dmateusp avatar Apr 18 '24 15:04 dmateusp

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 19 '24 16:05 github-actions[bot]

I think this would be a good idea

derekargueta avatar May 20 '24 05:05 derekargueta

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 19 '24 12:06 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Jun 26 '24 12:06 github-actions[bot]