envoy icon indicating copy to clipboard operation
envoy copied to clipboard

On-demand filter in Envoy not working with POST requests

Open maoyutao opened this issue 1 year ago • 3 comments

I have been using the OnDemand plugin in Envoy and I've encountered an issue during testing.

When the first request is a GET request, everything works as expected and the request returns a 200 status code. However, when the first request is a POST request, Envoy returns a 404 status code.

I suspect the issue might be related to this part of the code: https://github.com/envoyproxy/envoy/blob/f580ed067db0f2a48085aa33e45a3a9cf5e36bfe/source/extensions/filters/http/on_demand/on_demand_update.cc#L206

There is no description of this behavior in the documentation. I would like to know if this is due to incorrect usage on my part or if the plugin indeed only supports GET requests.

Environment: Envoy version: 1.28

maoyutao avatar Apr 08 '24 06:04 maoyutao

cc: @dmitri-d @htuch @kyessenov

RyanTheOptimist avatar Apr 08 '24 14:04 RyanTheOptimist

Yeah, seems so from that code and looking at on_demand_integration_test.cc, I don't see any POST tests, so I would consider this unsupported.

htuch avatar Apr 09 '24 04:04 htuch

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 09 '24 08:05 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar May 16 '24 08:05 github-actions[bot]