envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Formally deprecate `*_METADATA` access log command operators

Open jbohanon opened this issue 1 year ago • 5 comments

Title: Formally deprecate *_METADATA access log command operators

Description: The documentation for the command operators for access log formatting DYNAMIC_METADATA and CLUSTER_METADATA has indicated that these will be deprecated in favor of the METADATA formatter since the latter was implemented. We should actually deprecate these and make plans for their removal.

Relevant Links: https://github.com/envoyproxy/envoy/pull/17457/files#diff-a5eb61dd3a95c605846ebaba934b7334bc18f96fbf9ebf7593a90948c92f19c5

jbohanon avatar Mar 20 '24 15:03 jbohanon

Correct, this has been on my plate for a while, so I can drive deprecation. METADATA is right now an extension and I believe that in order to deprecate *_METADATA, the generic formatted must be moved out of extensions to core formatters.

cpakulski avatar Mar 20 '24 20:03 cpakulski

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 20 '24 08:04 github-actions[bot]

@cpakulski is this actively in progress or should we tag it help-wanted

jbohanon avatar Apr 20 '24 09:04 jbohanon

@jbohanon Thanks for reminding. It will be done for the next release.

cpakulski avatar Apr 22 '24 14:04 cpakulski

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 22 '24 16:05 github-actions[bot]