envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Wildcard records support in DNS filter inline table

Open StupidScience opened this issue 1 year ago • 10 comments

Add support for wildcard records in DNS filter inline table

I've tested locally and DNS filter doesn't seem to support wildcard records for inline table, e.g. snippet below does not match abc.example.com and forward request to configured resolvers.

inline_dns_table:
  virtual_domains:
    - name: "*.example.com"
      endpoint:
        address_list:
          address:
          - 127.0.5.5

Didn't find any other available options to configure this in docs so I assume it is not supported yet.

StupidScience avatar Mar 16 '24 14:03 StupidScience

cc @mattklein123 @yanjunxiang-google

nezdolik avatar Mar 16 '24 22:03 nezdolik

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 16 '24 00:04 github-actions[bot]

/wait

yanjunxiang-google avatar Apr 16 '24 02:04 yanjunxiang-google

/assign @botengyao

yanjunxiang-google avatar Apr 16 '24 02:04 yanjunxiang-google

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 16 '24 08:05 github-actions[bot]

@yanjunxiang-google @botengyao is there any movement around this? Is it going to be implemented or is there any consensus if this feature is desired at all?

StupidScience avatar May 16 '24 14:05 StupidScience

/wait

yanjunxiang-google avatar May 20 '24 12:05 yanjunxiang-google

@StupidScience AFAIK, currently dns_filter does not support wildcard DNS records in its internal table. The DNS search is based on the exact host-name matching.

yanjunxiang-google avatar May 21 '24 17:05 yanjunxiang-google

@yanjunxiang-google I understand but is it going to be supported?

StupidScience avatar May 21 '24 18:05 StupidScience

@StupidScience I think it will be a nice thing to have. Please feel free to contribute on this.

yanjunxiang-google avatar May 22 '24 16:05 yanjunxiang-google

@yanjunxiang-google I sent https://github.com/envoyproxy/envoy/pull/34588 addressing this

StupidScience avatar Jun 06 '24 15:06 StupidScience

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 06 '24 16:07 github-actions[bot]