envoy
envoy copied to clipboard
envoyproxy
http3: Add support for HTTP/3 METADATA
http3: Add support for HTTP/3 METADATA
Adds a new allow_metadata option to Http3ProtocolOptions.
Risk Level: Low, protected by new config option Testing: New integration tests Docs Changes: N/A Release Notes: Updated
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/32568 was opened by RyanTheOptimist.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
Sorry! I keep forgetting that Envoy does automatic assignment. I think the code in this PR is basically ready for review, but it depends on some un-commited QUICHE changes that I manually passed in so it won't yet pass CI
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/32568 was synchronize by RyanTheOptimist.
/assign @danzh2010
Ok, this is ready for review, I hope. There's a QUICHE update in this as well, but I'll land that separately once #32642 lands.
Now that #32650 has landed, this PR does not change deps, so I'll remove that label.
@alyssawilk PTAL. The QUICHE update which the size limit tests require will be landed in #32892. In the meantime, I've patched that .bzl file change into this PR so I'll need a main merge once that lands. But it's ready for review, I think!
looks like test/integration/protocol_integration_test.cc has some Metadata tests as well as http2_flood_integration_test.cc
Given it's hidden and we're the only users I'm OK with a TODO to turn those up and landing to kick off import - your call if that's helpful or if you want to just land the right proper fix :-)
Thanks! Yeah, if it's ok with you, I'd love to address this in a follow up. Hopefully it's straightforward :)