envoy icon indicating copy to clipboard operation
envoy copied to clipboard

http_health_check: host and path validation

Open botengyao opened this issue 1 year ago • 2 comments

The previous host and path value cannot pass the header validation.

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

botengyao avatar Feb 22 '24 15:02 botengyao

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32521 was opened by botengyao.

see: more, trace.

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @adisuissa CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32521 was opened by botengyao.

see: more, trace.

@envoyproxy/senior-maintainers assignee is @htuch

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/32521#pullrequestreview-1903632648 was submitted by @adisuissa.

see: more, trace.

Not sure if it requires a release note or not, and will leave the decision to the senior maintainer.

adisuissa avatar Feb 27 '24 14:02 adisuissa

friendly ping @yanavlasov

KBaichoo avatar Mar 05 '24 14:03 KBaichoo

@yanavlasov would you mind taking another pass?

nezdolik avatar Mar 11 '24 13:03 nezdolik

/wait-any

yanavlasov avatar Mar 25 '24 20:03 yanavlasov

LGTM. Please merge main to resolve the coverage error.

yanavlasov avatar Mar 27 '24 16:03 yanavlasov