envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Bump c-ares to 1.26.0

Open fredyw opened this issue 1 year ago • 5 comments

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

fredyw avatar Feb 14 '24 18:02 fredyw

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32405 was opened by fredyw.

see: more, trace.

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @htuch

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32405 was opened by fredyw.

see: more, trace.

Looks like legit failures in CI https://dev.azure.com/cncf/envoy/_build/results?buildId=162441&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=2181edf2-f610-59f2-c43a-04bb9d0bca00

htuch avatar Feb 16 '24 14:02 htuch

Looks like legit failures in CI https://dev.azure.com/cncf/envoy/_build/results?buildId=162441&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=2181edf2-f610-59f2-c43a-04bb9d0bca00

Yeah, there are behavior changes in c-ares 1.26, for example when the search domain is empty, it will return ARES_ENOBADNAME instead of ARES_ENODATA or ARES_ENOTFOUND, etc, which is probably the correct thing to do, but a lot of the existing tests expect ARES_NODATA or ARES_NOTFOUND when the search domain is empty.

fredyw avatar Feb 16 '24 16:02 fredyw

1.27.0 was just released - https://github.com/c-ares/c-ares/releases/tag/cares-1_27_0. It would be good to catch this dep up. I'll try to look at the changed behavior over the weekend

moderation avatar Feb 23 '24 19:02 moderation

Looks like legit failures in CI https://dev.azure.com/cncf/envoy/_build/results?buildId=162441&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=2181edf2-f610-59f2-c43a-04bb9d0bca00

Yeah, there are behavior changes in c-ares 1.26, for example when the search domain is empty, it will return ARES_ENOBADNAME instead of ARES_ENODATA or ARES_ENOTFOUND, etc, which is probably the correct thing to do, but a lot of the existing tests expect ARES_NODATA or ARES_NOTFOUND when the search domain is empty.

looks like it will return ARES_EBADNAME in 1.27.0 instead of ARES_EDESTRUCTION in 1.20.1

zirain avatar May 01 '24 15:05 zirain