envoy icon indicating copy to clipboard operation
envoy copied to clipboard

config: validating duration wkt using Envoy validator

Open adisuissa opened this issue 1 year ago • 13 comments

Commit Message: config: validating duration wkt using Envoy validator and restricting durations to 292 years. Additional Description: Stricter validation of a google.protobuf.Duration field in a config, rejecting negative values. This can be temporarily reverted by setting runtime guard envoy.reloadable_features.strict_duration_validation to false. Restricting durations to 292 years allows us to have a single validator for both seconds and milliseconds. Risk Level: low Testing: Added unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.strict_duration_validation

Fixes fuzz issue 65802

adisuissa avatar Feb 13 '24 20:02 adisuissa

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32376 was opened by adisuissa.

see: more, trace.

/wait

kyessenov avatar Feb 22 '24 19:02 kyessenov

/assign-from @envoyproxy/senior-maintainers

adisuissa avatar Feb 27 '24 22:02 adisuissa

@envoyproxy/senior-maintainers assignee is @ggreenway

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/32376#issuecomment-1967704770 was created by @adisuissa.

see: more, trace.

/wait

For CI, minor comment

KBaichoo avatar Mar 05 '24 14:03 KBaichoo

looks like ci is still failing

nezdolik avatar Mar 11 '24 13:03 nezdolik

/wait

nezdolik avatar Mar 11 '24 13:03 nezdolik

/wait on CI passing

ggreenway avatar Mar 19 '24 17:03 ggreenway

/wait on CI passing

ggreenway avatar Mar 25 '24 19:03 ggreenway

Let's wait until v1.30 is cut. /wait-any

adisuissa avatar Apr 12 '24 13:04 adisuissa

/wait

RyanTheOptimist avatar May 09 '24 15:05 RyanTheOptimist

/wait on CI

RyanTheOptimist avatar May 10 '24 13:05 RyanTheOptimist

/retest

adisuissa avatar May 10 '24 16:05 adisuissa