envoy
envoy copied to clipboard
config: validating duration wkt using Envoy validator
Commit Message: config: validating duration wkt using Envoy validator and restricting durations to 292 years.
Additional Description:
Stricter validation of a google.protobuf.Duration
field in a config, rejecting negative values. This can be temporarily reverted by setting runtime guard envoy.reloadable_features.strict_duration_validation
to false.
Restricting durations to 292 years allows us to have a single validator for both seconds and milliseconds.
Risk Level: low
Testing: Added unit tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.strict_duration_validation
Fixes fuzz issue 65802
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc)
.
/wait
/assign-from @envoyproxy/senior-maintainers
@envoyproxy/senior-maintainers assignee is @ggreenway
/wait
For CI, minor comment
looks like ci is still failing
/wait
/wait on CI passing
/wait on CI passing
Let's wait until v1.30 is cut. /wait-any
/wait
/wait on CI
/retest