envoy icon indicating copy to clipboard operation
envoy copied to clipboard

cel cleanup: upgrade and remove patch to fix macos

Open ggreenway opened this issue 1 year ago • 2 comments

#32148 is adding a patch to fix macOS. This should become unnecessary after CEL is upgraded to https://github.com/google/cel-cpp/commit/16ca259aeea2330998f3665c289267a82a738d46 or newer.

However, there's an issue with absl: latest CEL uses absl/base:no_destructor, which was added to absl on 2023-11-08, but envoy is on absl 20230802.1. So an absl upgrade will be required before CEL can be upgraded.

ggreenway avatar Feb 07 '24 21:02 ggreenway

cc @yanavlasov @envoyproxy/dependency-shepherds

alyssawilk avatar Feb 07 '24 21:02 alyssawilk

I have tried to update CEL. We also need to update googleapis. More importantly is this:

external/com_google_cel_cpp/common/sized_input_view.h:535:40: error: designated initializers are a C++20 extension [-Werror,-Wc++20-designator]
               OperationInput{.copy = {.src = &other.range_, .dest = &range_}}))

Are we close to C++20 as a minimum in Envoy? If not, I'd have to go and undo some C++20 changes in CEL CPP.

kyessenov avatar Feb 23 '24 21:02 kyessenov

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 25 '24 00:03 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Apr 01 '24 04:04 github-actions[bot]