envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

healthcheck: support TCP health check with ProxyProtocol

Open Shikugawa opened this issue 1 year ago • 12 comments

Commit Message: healthcheck: support TCP health check with ProxyProtocol Additional Description: This PR aims to support TCP healthcheck with ProxyProtocol. This feature is useful to ensure Proxy Protocol is enabled or not from upstream servers. It works in addition to normal TCP based healthcheck. This feature is the equivalent with check-send-proxy provided by HAProxy. https://cbonte.github.io/haproxy-dconv/2.0/configuration.html#5.2-check-send-proxy Risk Level: Low Testing: Unit/Integration Docs Changes: Required Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

Shikugawa avatar Jan 08 '24 12:01 Shikugawa

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @lizan CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/31691 was opened by Shikugawa.

see: more, trace.

repokitteh-read-only[bot] avatar Jan 08 '24 12:01 repokitteh-read-only[bot]

/lgtm api

@zuercher for owner review

lizan avatar Jan 10 '24 01:01 lizan

@zuercher friendly ping

Shikugawa avatar Jan 16 '24 06:01 Shikugawa

/lgtm api

lizan avatar Jan 19 '24 06:01 lizan

@Shikugawa one last thing, can you add a release note for the new field?

lizan avatar Jan 19 '24 06:01 lizan

Sorry, I failed to note that we need a second code reviewer before merging. @botengyao can you have a look?

zuercher avatar Jan 24 '24 23:01 zuercher

/wait

zuercher avatar Feb 20 '24 17:02 zuercher

ping @Shikugawa

zuercher avatar Mar 13 '24 04:03 zuercher

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 12 '24 08:04 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 19 '24 08:04 github-actions[bot]

@botengyao @zuercher i think this is waiting for final review

phlax avatar May 06 '24 09:05 phlax

@zuercher Fixed conflict. Could you please approve again?

Shikugawa avatar May 11 '24 07:05 Shikugawa

/retest

ravenblackx avatar May 14 '24 15:05 ravenblackx