envoy icon indicating copy to clipboard operation
envoy copied to clipboard

refactor: factory cleanup

Open alyssawilk opened this issue 3 years ago • 1 comments

As follow-on clean up for upstream filters, cleaning up more factory code.

Risk Level: low Testing: existing tests Docs Changes: n/a Release Notes: n/a

alyssawilk avatar Sep 22 '22 15:09 alyssawilk

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23208 was opened by alyssawilk.

see: more, trace.

So there can be different TransportSocketFactoryContextImpls over the lifetime of the server. The members which I changed should not change over the lifetime of the server - things like access log manager, and the main thread dispatcher. the stats scope and the init manager do need to be specific to the local context rather than the global server context.

alyssawilk avatar Sep 28 '22 16:09 alyssawilk

So there can be different TransportSocketFactoryContextImpls over the lifetime of the server. The members which I changed should not change over the lifetime of the server - things like access log manager, and the main thread dispatcher. the stats scope and the init manager do need to be specific to the local context rather than the global server context.

Thanks for the explanation! LGTM!

adisuissa avatar Sep 28 '22 16:09 adisuissa