envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Enable Http1ServerConnectionImplTest.Utf8Path for BalsaParser.

Open bencebeky opened this issue 3 years ago • 1 comments

This test does not fail for me locally. The current PR is to find out what presubmit test fails on GitHub.

Signed-off-by: Bence Béky [email protected]

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

bencebeky avatar Sep 20 '22 19:09 bencebeky

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23187 was opened by bencebeky.

see: more, trace.

/assign @yanavlasov @alyssawilk

bencebeky avatar Sep 27 '22 16:09 bencebeky

PTAL. It would be difficult to change the internals of Balsa to be permissive in this case. Do you think this is okay?

bencebeky avatar Sep 27 '22 16:09 bencebeky