envoy icon indicating copy to clipboard operation
envoy copied to clipboard

stateful_session: Add Header based session state

Open Pawan-Bishnoi opened this issue 3 years ago • 2 comments
trafficstars

Commit Message: "stateful_session: Add Header based session state"

Additional Description: Envoy already supports cookie based state management for sticky sessions. This PR adds one more option - header based state management (as discussed here). The header name is configurable via API. The responsibility to pass the said header with every request falls on the client. ~~The rest of the behaviour is consistent with the cookie based approach.~~ Path match is only available via StatefulSessionPerRoute.

(Reviewers may refer the existing cookie based implementation while reviewing this)

Risk Level: Low Testing: Unit & Integration tests added. Docs Changes: Added. Release Notes: Waiting. Platform Specific Features: N/A Fixes #22475

API Considerations:

  1. Looking for guidance on this point. I have kept the new proto files in this repo to keep them consistent with the cookie based approach.
  2. Could not find any guidance about updating the codeowners file, please see if that needs to be corrected.

Pawan-Bishnoi avatar Sep 16 '22 12:09 Pawan-Bishnoi

Hi @Pawan-Bishnoi, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23145 was opened by Pawan-Bishnoi.

see: more, trace.

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @lizan CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23145 was opened by Pawan-Bishnoi.

see: more, trace.

done @lizan Ptal.

Pawan-Bishnoi avatar Sep 28 '22 11:09 Pawan-Bishnoi

@wbpcode ptal.

Pawan-Bishnoi avatar Oct 10 '22 04:10 Pawan-Bishnoi

/wait-any

wbpcode avatar Oct 10 '22 05:10 wbpcode