envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

[WIP] Improve the coverage report for Wasm

Open ingwonsong opened this issue 2 years ago • 12 comments

Signed-off-by: Ingwon Song [email protected]

Fixes https://github.com/envoyproxy/envoy/issues/11986

ingwonsong avatar Sep 09 '22 22:09 ingwonsong

/assign-from @envoyproxy/first-pass-reviewers

htuch avatar Sep 12 '22 13:09 htuch

@envoyproxy/first-pass-reviewers assignee is @daixiang0

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1243768210 was created by @htuch.

see: more, trace.

repokitteh-read-only[bot] avatar Sep 12 '22 13:09 repokitteh-read-only[bot]

/retest

ingwonsong avatar Sep 12 '22 19:09 ingwonsong

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1244166549 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Sep 12 '22 19:09 repokitteh-read-only[bot]

/retest

ingwonsong avatar Sep 12 '22 23:09 ingwonsong

Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1244686583 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Sep 12 '22 23:09 repokitteh-read-only[bot]

Please make CI happy then remove WIP prefix, thanks.

daixiang0 avatar Sep 16 '22 03:09 daixiang0

/retest

ingwonsong avatar Sep 19 '22 19:09 ingwonsong

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1251422948 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Sep 19 '22 19:09 repokitteh-read-only[bot]

/retest

ingwonsong avatar Sep 20 '22 12:09 ingwonsong

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1252254706 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Sep 20 '22 12:09 repokitteh-read-only[bot]

I will take a time to figure out alternative ways.

ingwonsong avatar Sep 22 '22 19:09 ingwonsong

I will take a time to figure out alternative ways.

Thanks! /wait

adisuissa avatar Sep 23 '22 12:09 adisuissa

Please don't use force push @ingwonsong which will make review become more hard. Thanks.

Feel free mark this PR to be ready for review, once it is ok for a formal review.

wbpcode avatar Oct 17 '22 06:10 wbpcode

/retest

ingwonsong avatar Oct 18 '22 00:10 ingwonsong

Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1281647524 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Oct 18 '22 00:10 repokitteh-read-only[bot]

@daixiang0 Can you please review this PR?

ingwonsong avatar Oct 18 '22 03:10 ingwonsong

cc @PiotrSikora Hi，could you take a look to this PR when you have free time.

/assign @PiotrSikora

wbpcode avatar Oct 21 '22 07:10 wbpcode

/wait

wrowe avatar Oct 26 '22 05:10 wrowe

/retest

ingwonsong avatar Nov 03 '22 15:11 ingwonsong

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23055#issuecomment-1302301550 was created by @ingwonsong.

see: more, trace.

repokitteh-read-only[bot] avatar Nov 03 '22 15:11 repokitteh-read-only[bot]

@lizan could you give this another look, thanks

phlax avatar Nov 08 '22 08:11 phlax

/wait-any

phlax avatar Nov 10 '22 10:11 phlax

@lizan friendly ping.

ingwonsong avatar Nov 17 '22 22:11 ingwonsong

Needs main merge.

jmarantz avatar Nov 23 '22 13:11 jmarantz

headsup that we just landed #24169 as a temporary resolution to issues described in #24164

phlax avatar Nov 24 '22 09:11 phlax

Resolve the conflict.

@phlax I reverted the changes in this PR for per_file_coverage.sh. We may need to address again after resolving of the issue https://github.com/envoyproxy/envoy/issues/24164

ingwonsong avatar Nov 29 '22 19:11 ingwonsong

@lizan Warm reminder.

ingwonsong avatar Dec 01 '22 22:12 ingwonsong

@adisuissa Can you take a look at this?

ingwonsong avatar Dec 06 '22 01:12 ingwonsong

Merging, as @lizan approved the PR.

adisuissa avatar Dec 06 '22 01:12 adisuissa