envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

fix sendLocalResponse in wasm

Open johnlanni opened this issue 2 years ago • 1 comments

fix #23047

Commit Message: Additional Description: Risk Level: low Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

johnlanni avatar Sep 09 '22 08:09 johnlanni

/wait

mathetake avatar Sep 20 '22 02:09 mathetake

https://dev.azure.com/cncf/envoy/_build/results?buildId=117861&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=21e6aa7d-f369-5abd-5e4e-e888cac18e9c

https://github.com/envoyproxy/envoy/blob/f09ed3646b88fae777a060be37f3224dfa67f428/source/extensions/common/wasm/context.h#L30

There seems to be a problem with this clang tidy check, this using will be used in the context.cc like:

https://github.com/envoyproxy/envoy/blob/f09ed3646b88fae777a060be37f3224dfa67f428/source/extensions/common/wasm/context.cc#L152

johnlanni avatar Oct 01 '22 14:10 johnlanni