envoy Update documentation for how 5xxs map to TCP traffic

Update documentation for how 5xxs map to TCP traffic

Open chusteven opened this issue 3 years ago • 3 comments

Updating documentation to make clearer this issue: https://github.com/envoyproxy/envoy/issues/3058

Risk Level: Low since it's just documentation? Testing: Didn't do any -- happy to but was too lazy to set up my environment 😅 Docs Changes: Specifically for outlier detection, I was confused that 5xx mapped -- for TCP traffic -- to connection failures Release Notes: Updated documentation on outlier detection Platform Specific Features: N/A [Optional Runtime guard:] ? [Optional Fixes #Issue] https://github.com/envoyproxy/envoy/issues/3058 [Optional Fixes commit #PR or SHA] N/A [Optional Deprecated:] N/A [Optional API Considerations:] N/A

Aug 31 '22 01:08 chusteven

Hi @chusteven, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/22909 was opened by chusteven.

see: more, trace.

Aug 31 '22 01:08 repokitteh-read-only[bot]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto). CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @htuch CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/22909 was opened by chusteven.

see: more, trace.

Aug 31 '22 01:08 repokitteh-read-only[bot]

Please fix DCO. /wait