envoy icon indicating copy to clipboard operation
envoy copied to clipboard

[balsa] Reject invalid characters.

Open bencebeky opened this issue 3 years ago • 5 comments

Signed-off-by: Bence Béky [email protected]

Commit Message: [balsa] Reject invalid characters. Additional Description: Protected by default-false runtime flag. Risk Level: low Testing: //test/common/http/http1:codec_impl_test Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

bencebeky avatar Aug 09 '22 18:08 bencebeky

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/22629 was opened by bencebeky.

see: more, trace.

Dianna, Biren, PTAL.

/assign @diannahu @birenroy

bencebeky avatar Aug 09 '22 20:08 bencebeky

/assign @KBaichoo

bencebeky avatar Aug 10 '22 19:08 bencebeky

PTAL. I added some more test changes.

bencebeky avatar Aug 10 '22 20:08 bencebeky

also is this still draft? Thanks

Oops, it's ready for review, marking it as such...

bencebeky avatar Aug 11 '22 16:08 bencebeky

/wait

KBaichoo avatar Aug 15 '22 15:08 KBaichoo