envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Support for month, year ratelimit units

Open renuka-fernando opened this issue 2 years ago • 1 comments

Title: Support for month, year ratelimit units

Description: Rate limits such as 10K req/Month, 1M req/year are useful when the upstream has a business value (like a per month subscription) and is exposed the client via Envoy.

The existing implementation only supports the following units.

  • SECOND
  • MINUTE
  • HOUR
  • DAY

Maybe MONTH, YEAR units are not useful for local rate limiting but may useful for global rate limiting.

[optional Relevant Links:] https://github.com/envoyproxy/data-plane-api/blob/5ba669d8a54e7c4bbbba3a6445ebd1a09d9e9dc0/envoy/service/ratelimit/v3/rls.proto#L80-L95

renuka-fernando avatar Aug 09 '22 16:08 renuka-fernando

It seems pretty ambitious to expect the same configuration to run for MONTHs or YEARs. So I'd imagine a global rate limiting will only issue shorter lived quota. cc @sergiitk @markdroth

kyessenov avatar Aug 10 '22 16:08 kyessenov

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 09 '22 20:09 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Sep 17 '22 00:09 github-actions[bot]