envoy
envoy copied to clipboard
admin: Remove admin callback url param
Commit Message: remove superfluous url argument from the args passed to admin callback.s That is available, if needed, from admin_stream.requestHeaders().getPathValue(). Generally it was only used for parsing query-params. Those should be obtained from admin_stream.queryParam() which will also parse query-params out of the body if they came in that way, e.g. from a POST. Additional Description: Risk Level: low -- this is a non-functional change that just removes arguments from an API that is no longer used as of https://github.com/envoyproxy/envoy/pull/22424 Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
/retest
Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit
/retest
Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit
/retest
Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit
/assign-from envoyproxy/senior-maintainers