envoy icon indicating copy to clipboard operation
envoy copied to clipboard

admin: Remove admin callback url param

Open jmarantz opened this issue 3 years ago • 5 comments

Commit Message: remove superfluous url argument from the args passed to admin callback.s That is available, if needed, from admin_stream.requestHeaders().getPathValue(). Generally it was only used for parsing query-params. Those should be obtained from admin_stream.queryParam() which will also parse query-params out of the body if they came in that way, e.g. from a POST. Additional Description: Risk Level: low -- this is a non-functional change that just removes arguments from an API that is no longer used as of https://github.com/envoyproxy/envoy/pull/22424 Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

jmarantz avatar Aug 04 '22 22:08 jmarantz

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/22571 was opened by jmarantz.

see: more, trace.

/retest

jmarantz avatar Aug 05 '22 00:08 jmarantz

Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22571#issuecomment-1205900896 was created by @jmarantz.

see: more, trace.

/retest

jmarantz avatar Aug 05 '22 03:08 jmarantz

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22571#issuecomment-1206006060 was created by @jmarantz.

see: more, trace.

/retest

jmarantz avatar Aug 12 '22 00:08 jmarantz

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22571#issuecomment-1212623269 was created by @jmarantz.

see: more, trace.

/assign-from envoyproxy/senior-maintainers

jmarantz avatar Aug 16 '22 21:08 jmarantz

envoyproxy/senior-maintainers assignee is @htuch

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22571#issuecomment-1217188183 was created by @jmarantz.

see: more, trace.