envoy icon indicating copy to clipboard operation
envoy copied to clipboard

tools: fix print_dependencies.py target error

Open rmstoi opened this issue 2 years ago • 9 comments

Fix error if target is passed to tools/print_dependencies.py

For example: $ tools/print_dependencies.py //envoy/ssl:handshaker_interface Traceback (most recent call last): File "/envoy/envoy/tools/print_dependencies.py", line 48, in for line in output.split('\n'): TypeError: a bytes-like object is required, not 'str'

Signed-off-by: Ruslan Mstoi [email protected]

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

rmstoi avatar Aug 03 '22 16:08 rmstoi

/retest

rmstoi avatar Aug 04 '22 08:08 rmstoi

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22545#issuecomment-1204961715 was created by @rmstoi.

see: more, trace.

/retest

rmstoi avatar Aug 04 '22 12:08 rmstoi

Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22545#issuecomment-1205175780 was created by @rmstoi.

see: more, trace.

/wait on CI

alyssawilk avatar Aug 04 '22 12:08 alyssawilk

hi @rmstoi apologies for slow review

with this script im wondering if it would be better to just remove it - its not currently used anywhere - i think it is left over from previous usage

phlax avatar Aug 18 '22 09:08 phlax

Hi @phlax, thanks for review.

This PR is to fix a crash: get the script working if target is passed to it. If you think the script is obsolete should I make another PR to remove the script instead?

rmstoi avatar Aug 18 '22 09:08 rmstoi

If you think the script is obsolete should I make another PR to remove the script instead?

probably yes - i checked with other maintainers - and i dont think this is used any more - so rather remove the maintenance burden

phlax avatar Aug 18 '22 09:08 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 17 '22 12:09 github-actions[bot]

Created #23223 to remove the script. Hence, closing this PR.

rmstoi avatar Sep 23 '22 11:09 rmstoi