envoy
envoy copied to clipboard
tools: fix print_dependencies.py target error
Fix error if target is passed to tools/print_dependencies.py
For example:
$ tools/print_dependencies.py //envoy/ssl:handshaker_interface
Traceback (most recent call last):
File "/envoy/envoy/tools/print_dependencies.py", line 48, in
Signed-off-by: Ruslan Mstoi [email protected]
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
/retest
Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit
/retest
Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit
/wait on CI
hi @rmstoi apologies for slow review
with this script im wondering if it would be better to just remove it - its not currently used anywhere - i think it is left over from previous usage
Hi @phlax, thanks for review.
This PR is to fix a crash: get the script working if target is passed to it. If you think the script is obsolete should I make another PR to remove the script instead?
If you think the script is obsolete should I make another PR to remove the script instead?
probably yes - i checked with other maintainers - and i dont think this is used any more - so rather remove the maintenance burden
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Created #23223 to remove the script. Hence, closing this PR.