envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Cel vocab

Open ashankar1 opened this issue 3 years ago • 30 comments
trafficstars

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

ashankar1 avatar Feb 04 '22 19:02 ashankar1

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/19827 was opened by ashankar1.

see: more, trace.

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @htuch CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/). CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @moderation

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/19827 was opened by ashankar1.

see: more, trace.

/assign @RyanTheOptimist

ashankar1 avatar Feb 15 '22 23:02 ashankar1

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1041821858 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1044587902 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1044917339 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1045325880 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Check envoy-presubmit didn't fail.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1046308710 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1057439488 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1057562423 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Check envoy-presubmit didn't fail.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1057582575 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1058174277 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1058378122 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1058386865 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Check envoy-presubmit didn't fail.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1058508643 was created by @ashankar1.

see: more, trace.

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1059225557 was created by @ashankar1.

see: more, trace.

/retest

ashankar1 avatar Mar 10 '22 20:03 ashankar1

Retrying Azure Pipelines:

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/19827#issuecomment-1064465220 was created by @ashankar1.

see: more, trace.

@ashankar1 there are several merge conflicts; please resolve.

ggreenway avatar Mar 16 '22 17:03 ggreenway

@ashankar1 seems like this is failing python yapf formatting - this should have uploaded a fix as artefact (i may well have broken this and will look further)

either way this is the diff/fix that should have been posted

--- /source/tools/extensions/extensions_check.py	(original)
+++ /source/tools/extensions/extensions_check.py	(reformatted)
@@ -53,7 +53,8 @@
     "envoy.sip_proxy.filters", "envoy.transport_sockets.downstream",
     "envoy.transport_sockets.upstream", "envoy.tls.cert_validator", "envoy.upstreams",
     "envoy.wasm.runtime", "envoy.common.key_value", "envoy.network.dns_resolver",
-    "envoy.rbac.matchers", "envoy.access_loggers.extension_filters", "envoy.http.stateful_session", "envoy.expr.custom_cel_vocabulary")
+    "envoy.rbac.matchers", "envoy.access_loggers.extension_filters", "envoy.http.stateful_session",
+    "envoy.expr.custom_cel_vocabulary")
 
 EXTENSION_STATUS_VALUES = (
     # This extension is stable and is expected to be production usable.

phlax avatar Mar 22 '22 15:03 phlax

@ashankar1 please let me know when this is read for another review pass, thanks.

htuch avatar Mar 23 '22 03:03 htuch

/wait

htuch avatar Mar 23 '22 03:03 htuch

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 22 '22 08:04 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 22 '22 20:05 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 22 '22 00:06 github-actions[bot]

wait/

ashankar1 avatar Jun 22 '22 00:06 ashankar1

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 22 '22 04:07 github-actions[bot]

/wait

ashankar1 avatar Aug 18 '22 17:08 ashankar1

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 17 '22 20:09 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 19 '22 00:10 github-actions[bot]