envoy icon indicating copy to clipboard operation
envoy copied to clipboard
verified publisher icon envoyproxy

set_node_on_first_message_only should be implemented for delta xDS

Open htuch opened this issue 4 years ago • 3 comments

Currently this option only appears implemented for SotW. It's likely this might be handled in https://github.com/envoyproxy/envoy/pull/14496 for free, but opening a tracking ticket to ensure we validate this behavior with tests. CC @dmitri-d

htuch avatar Feb 07 '21 18:02 htuch

It is indeed being handled by GrpcMuxDelta (skip_subsequent_node parameter): https://github.com/envoyproxy/envoy/pull/14496/files#diff-3d9b7f541cceecbc0ee4f3ff9972955b13408dd67823e05a1be1a6ed8b6ab064R309

dmitri-d avatar Feb 09 '21 02:02 dmitri-d

FWIW, when we enabled this option in our SotW implementation our control plane CPU dropped in half. Given delta will likely have more XDS requests, this will probably be more important. So great to see this will be supported :+1:

howardjohn avatar Feb 18 '21 22:02 howardjohn

/assign @antoniovleonti

antoniovleonti avatar Dec 10 '25 21:12 antoniovleonti